Review 14.3 Merged

95329[BUGFIX] Mark multi checkbox groups as role="group"

Stefan Bürk CR +2 V +2 Normal +49 −2 updated 08/14/26, 13:39

Commit message

The container wrapping the checkboxes carried role="radiogroup", the
same attribute the radio button partial uses, where it is correct.

radiogroup states that the group owns radios and that exactly one of
them may be selected, so assistive technology announces a set of
checkboxes as a single-choice group. WAI-ARIA requires the owned
elements of a radiogroup to carry role="radio"; the mismatch is
reported as aria-required-children.

The role becomes "group", which is what a set of related checkboxes
is. It is corrected rather than dropped because renderFieldset is
configurable: without the fieldset, this attribute and its aria-label
are the only thing that groups the options.

The test renders a form through FormRuntime, which needs a language on
the request: TranslationService derives the locale from it, so element
labels cannot be resolved without one.

Added tests fixate this behavior.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk commented on patch set 1 08/14/26, 13:12

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/14/26, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106702

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 08/14/26, 13:39

  4. Stefan Bürk merged patch set 2 08/14/26, 13:39