Review main Merged

95386[BUGFIX] Restore expanded YAML dump in SiteWriter

Stefan Bürk CR +2 V +2 Normal +39 −24 updated 08/23/26, 14:48

Commit message

symfony/yaml v8.1.0 unintentionally rendered a mapping that is the
first element of a sequence item in a compact form, and degraded the
public DUMP_COMPACT_NESTED_MAPPING flag into a no-op along the way.
The "Upgrade to Symfony v8.1" change adapted the SiteWriter fixtures
to that output.

Upstream classified the change as a regression and restored the
previous format with v8.1.5, which turned the nightly unit max jobs
red without any Core change involved.

Revert the three expected fixtures to the expanded form, which is
byte identical to what v13 and v14 still write, and raise the
symfony/yaml constraint to ~8.1.5. The raise is required: the min
jobs resolved v8.1.0, which still contains the regression, so the
fixtures could otherwise not satisfy both ends of the allowed range.

Since SiteWriter rewrites the whole site configuration file on every
save, keeping the compact form would have reformatted the site
configuration of every user on the first save with v15.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Georg Ringer +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 68

  1. Stefan Bürk uploaded patch set 1 08/23/26, 13:51

  2. core-ci voted on patch set 1 V +1 08/23/26, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106988

  3. Stefan Bürk updated the commit message in patch set 2 V +1 08/23/26, 14:01

  4. core-ci voted on patch set 2 V +1 08/23/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/106990

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 08/23/26, 14:46

  6. Georg Ringer voted on patch set 2 CR +1 V +1 08/23/26, 14:47

  7. Stefan Bürk voted on patch set 2 CR +2 V +2 08/23/26, 14:48

  8. Stefan Bürk merged patch set 3 08/23/26, 14:48