#110521Restore expanded YAML dump format in SiteWriter
Description
Problem
The nightly pipeline for branch main fails in all unit max jobs since
2026-08-23. The commit is identical to the one that passed the day before, so
no TYPO3 change is involved. Only the dependency resolution moved.
Three tests of SiteWriterTest fail:
- writeOnlyWritesModifiedKeys
- writingOfNestedStructuresPreservesOrder
- writeAllowsPlaceholdersInImportedFiles
They compare the written site configuration against expected fixture files.
The dumped YAML changed from a compact rendering of a mapping inside a
sequence item to the expanded rendering.
Cause
The only relevant package change between the green and the red run is
symfony/yaml, from 8.1.2 to 8.1.5.
The compact rendering was never the symfony default. It was introduced
unintentionally with symfony/yaml 8.1.0, and it also degraded the public
dump flag for compact nested mappings into a no-op for plain valued mappings.
Upstream classified this as a regression and restored the previous output
with 8.1.5.
- symfony/symfony pull request 62967 introduced it
- symfony/symfony issue 65287 reported it
- symfony/symfony pull request 65365 reverted it, released as 8.1.5
Versions 8.1.3 and 8.1.4 do not exist for this component, so the step is a
single one.
TYPO3 adapted the fixtures to the regressed output in the change “Upgrade to
Symfony v8.1”. The expected fixture files were rewritten from the expanded to
the compact form there. The fixtures on 14.3 and 13.4 still carry the
expanded form and are byte identical to what main had before that change.
The input fixtures were never touched, so expected and input files currently
disagree with each other.
Consequence
SiteWriter rewrites the complete site configuration file on every save, so
the dumper default decides the on disk format of every site configuration,
and through the form YAML source also of every form definition saved from the
form editor. Keeping the compact form would reformat existing configuration
files of all users on the first save with v15. Restoring the expanded form
keeps the format that v13 and v14 write.
Solution
Revert the three expected fixture files to the expanded form, and raise the
symfony/yaml constraint so the whole allowed range behaves the same. The
minimum job currently resolves symfony/yaml 8.1.0, which still contains the
regression, so a fixture change alone would turn the minimum jobs red.
Reviews 1
Related issues 1
History 24
-
Gerrit Code Review pushed patch set 1 for main to change 95386 status
NewUnder Review <span data-processor="relativetime" data-value="2026-08-23T13:51:11+00:00" > 08/23/26, 13:51 </span> -
Gerrit Code Review pushed patch set 2 for main to change 95386 <span data-processor="relativetime" data-value="2026-08-23T14:01:47+00:00" > 08/23/26, 14:01 </span>
-
Stefan Bürk changed Related to #109043 <span data-processor="relativetime" data-value="2026-08-23T14:01:55+00:00" > 08/23/26, 14:01 </span>
-
Stefan Bürk commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-08-23T14:50:09+00:00" > 08/23/26, 14:50 </span>
Applied in changeset commit:c657b53904df996ea1bda79d44a30aabb0235556.