Review main Merged

95394[TASK] Use the containerised CGL suite in AGENTS.md

Benjamin Kott CR +2 V +2 Easy +1 −2 updated 08/24/26, 19:55

Commit message

AGENTS.md told coding agents to run the CGL fixer as
PHP_CS_FIXER_IGNORE_ENV=1 ./Build/Scripts/cglFixMyCommit.sh, in the
working mode section and in the commands overview. That environment
variable disables the PHP version check of php-cs-fixer, which is only
needed because the script runs the fixer with whatever php is in the
caller's PATH.

The document rules the direct invocation out itself a few sections
further down, and nothing is lost by following that rule:
runTests.sh -s cglGit runs the very same script inside the core testing
image, with the same file list and the same configuration, so the image
PHP makes the override unnecessary.

The file was introduced on all maintained branches with #110451 and is
identical on each of them, so the correction goes to the same set.
Otherwise the guidance drifts apart per branch.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Kott uploaded patch set 1 08/24/26, 11:25

  2. core-ci voted on patch set 1 V +1 08/24/26, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107028

  3. Georg Ringer voted on patch set 1 CR +1 V +1 08/24/26, 12:07

  4. Wouter Wolters voted on patch set 1 CR +1 V +1 08/24/26, 19:07

  5. Benjamin Kott voted on patch set 1 CR +2 V +2 08/24/26, 19:38

  6. Benjamin Kott merged patch set 2 08/24/26, 19:55