#110525Recommend runTests.sh -s cglGit for the CGL check in AGENTS.md
Description
AGENTS.md tells coding agents to run the CGL fixer as
PHP_CS_FIXER_IGNORE_ENV=1 ./Build/Scripts/cglFixMyCommit.sh
in two places: in “Working mode” and in the commands overview. Both should name
the containerised suite instead.
PHP_CS_FIXER_IGNORE_ENV=1 disables the PHP version check of php-cs-fixer. It is
only needed because the script runs the fixer with whatever php is in the
caller’s PATH, which is not necessarily a version php-cs-fixer supports. What it
buys is that the check stays silent rather than that the right interpreter is
used.
The same document rules the direct invocation out a few sections further down:
“Do not invoke phpunit, phpstan, php-cs-fixer, npm or grunt directly – the
wrapper supplies the PHP version, database service and bootstrap.”
There is nothing to lose by following that rule here, because
runTests.sh -s cglGit runs the very same script inside the core testing image:
cglGit)
${CONTAINER_BIN} run ${CONTAINER_COMMON_PARAMS} --name cgl-git-${SUFFIX} \
${IMAGE_PHP} Build/Scripts/cglFixMyCommit.sh ${CGLCHECK_DRY_RUN}
Same file list, same configuration, fixing by default, and -n is passed straight
through. Only the interpreter differs, and with the image’s PHP no override is
needed at all.
Reviews 3
History 25
-
Benjamin Kott changed description <span data-processor="relativetime" data-value="2026-08-24T11:22:00+00:00" > 08/24/26, 11:22 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 95394 status
NewUnder Review <span data-processor="relativetime" data-value="2026-08-24T11:25:11+00:00" > 08/24/26, 11:25 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 95404 <span data-processor="relativetime" data-value="2026-08-24T19:40:13+00:00" > 08/24/26, 19:40 </span>
-
Gerrit Code Review pushed patch set 1 for 13.4 to change 95405 <span data-processor="relativetime" data-value="2026-08-24T19:40:29+00:00" > 08/24/26, 19:40 </span>
-
Benjamin Kott commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-08-24T20:00:15+00:00" > 08/24/26, 20:00 </span>
Applied in changeset commit:bb7e70bb8452db3e8a0f44680a775faae9efae6f.