95395[BUGFIX] Save unsaved parent before following addRecord wizard
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Georg Ringer +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/backend/form-engine/field-control/add-record.ts+27 −1
- Build/Sources/TypeScript/backend/form-engine.ts+75 −0
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+56 −0
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+9 −1
- typo3/sysext/backend/Classes/Form/FormAction.php+14 −1
- typo3/sysext/backend/Resources/Private/Language/locallang_alt_doc.xlf+9 −0
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/field-control/add-record.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+3 −3
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+125 −0
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+16 −0
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_inline_1n_inline_1_child.php+8 −0
Review log 1418
-
Oli Bartsch uploaded patch set 1 08/24/26, 13:09
-
core-ci voted on patch set 1 V +1 08/24/26, 13:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107035
-
Oli Bartsch rebased onto patch set 2
V +108/27/26, 05:36 -
core-ci voted on patch set 2 V +1 08/27/26, 05:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107212
-
Georg Ringer voted on patch set 2 CR +1 V +1 08/27/26, 06:14
-
Anton Danilov commented on patch set 2 08/27/26, 10:36
I tested it on "main" and everything works fine. Can it be fixed for 13.4 too? -
Oli Bartsch commented on patch set 2 08/27/26, 14:56
Reply
Since it worked your you, would you like to vote the patch? Unfortunately, this is not a priority bugfix and therefore can not land into v13 anymore. However, you could just use a composer patch in those installations. -
Oli Bartsch uploaded patch set 3
CR +1V +108/27/26, 14:57 -
core-ci voted on patch set 3 V +1 08/27/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107276
-
Anton Danilov commented on patch set 3 V +1 08/27/26, 15:20
Reply
Thanks for the suggestion, but a composer patch isn't clean here - the fix also includes compiled JavaScript, so there's no straightforward way to patch it via composer on 13.4. Still, thanks for the patch. -
Georg Ringer voted on patch set 3 CR +1 V +1 09/01/26, 14:24
-
Benni Mack commented on patch set 3 CR -1 09/01/26, 20:59
I did a recursion check. Edit a sys_template. Hit the "add record" on the sys_templte.basedOn (level 1), on the new one, also create a new "basedOn" (level 2). Save the level 2, save level 1 and then all the previous GET parameters of the original record are gone. -
Benni Mack uploaded patch set 4
CR +1V +109/01/26, 21:13 -
core-ci voted on patch set 4 V +1 09/01/26, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107533
-
Benni Mack voted on patch set 4 CR +1 V +1 09/02/26, 09:57
-
Georg Ringer voted on patch set 4 CR +1 V +1 09/03/26, 06:21
-
Oli Bartsch commented on patch set 4 CR +2 V +2 09/03/26, 07:00
Reply
Done -
Oli Bartsch merged patch set 5 09/03/26, 07:00