#110526fieldControl.addRecord discards unsaved parent on unsaved IRRE child
Description
Clicking the plus-sign field control (fieldControl.addRecord) on a type=group/type=select field that belongs to a record which is itself still unsaved (e.g. a newly added IRRE/inline child that has not been saved yet) silently discards the unsaved parent and fails to link the newly created record back to it.
Wizard/AddController linking logic requires a persisted uid and has no way to resolve a NEW placeholder, so MathUtility::canBeInterpretedAsInteger() gating in AddController init/mainAction causes the link-back to be dropped.
Steps to reproduce
- Open a record with an IRRE/inline field.
- Click Create new to add a new unsaved inline child.
- On a group/select field of that unsaved child, click the plus-sign control to create a related record.
- The related record creation form appears, but once saved there is no confirmation and no way back – the unsaved parent data is lost and the relation is never linked.
Fix
A save-and-continue-to-add-record path saves the parent first, resolving the real uid via DataHandler substNEWwithIDs, then redirects into the Wizard/AddController flow, with a save/discard/keep-editing confirmation dialog when the parent has unsaved changes. The final redirect back to the edited document is computed server-side from the now-persisted editconf, not from a client-supplied returnUrl.
Reviews 2
History 2732
Show 7 earlier messages
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:29:52+00:00" > 08/24/26, 11:29 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:02+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:09+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:10+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:10+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:21+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:22+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:22+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:56+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:57+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:30:57+00:00" > 08/24/26, 11:30 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:06+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:07+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:07+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:07+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:08+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:09+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:10+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:19+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:20+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:20+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:28+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:28+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:29+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:29+00:00" > 08/24/26, 11:31 </span>
-
Oliver Bartsch changed description <span data-processor="relativetime" data-value="2026-08-24T11:31:46+00:00" > 08/24/26, 11:31 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 95395 status
NewUnder Review <span data-processor="relativetime" data-value="2026-08-24T13:10:01+00:00" > 08/24/26, 13:10 </span> -
Gerrit Code Review pushed patch set 2 for main to change 95395 <span data-processor="relativetime" data-value="2026-08-27T05:36:15+00:00" > 08/27/26, 05:36 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 95395 <span data-processor="relativetime" data-value="2026-08-27T14:58:01+00:00" > 08/27/26, 14:58 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 95395 <span data-processor="relativetime" data-value="2026-09-01T21:13:07+00:00" > 09/01/26, 21:13 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 95589 <span data-processor="relativetime" data-value="2026-09-03T07:00:07+00:00" > 09/03/26, 07:00 </span>
-
Oliver Bartsch commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-03T07:05:12+00:00" > 09/03/26, 07:05 </span>
Applied in changeset commit:4373fadcb84a06cff397f7359c936e87f874ff31.