Review 13.4 Merged

95401[BUGFIX] Use TypoScript from request in ConfirmationFinisher

Garvin Hicking CR +2 V +2 Easy +2 −1 updated 08/24/26, 20:44

Commit message

The `ConfirmationFinisher` currently retrieves `TypoScript` setup
directly from the `ConfigurationManager`.  This breaks the isolation
of indexing requests in EXT:solr, where a specific `TypoScript` context is expected.

Fix this by extracting the `TypoScript` from the request object provided
by the `finisherContext`.
This ensures proper delegation of `TypoScript` and context.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Garvin Hicking commented on patch set 1 08/24/26, 18:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/24/26, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107048

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 08/24/26, 20:44

  4. Garvin Hicking merged patch set 2 08/24/26, 20:44