Review 13.4 Merged

95403[BUGFIX] Use TypoScript from request in CObjectViewHelper

Garvin Hicking CR +2 V +2 Easy +2 −1 updated 08/24/26, 20:43

Commit message

The `CObjectViewHelper` currently retrieves `TypoScript` setup
directly from the `ConfigurationManager`.  This breaks the isolation
of indexing requests in EXT:solr, where a specific `TypoScript` context is expected.

Fix this by extracting the `TypoScript` from the request object provided
by the `renderingContext`. This ensures proper delegation of
`TypoScript` and context.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Garvin Hicking commented on patch set 1 08/24/26, 18:26

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php
  2. Garvin Hicking commented on patch set 2 08/24/26, 18:27

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 08/24/26, 18:27

  4. core-ci voted on patch set 2 V +1 08/24/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107052

  5. core-ci voted on patch set 1 V -1 08/24/26, 18:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107051

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 08/24/26, 20:43

  7. Garvin Hicking merged patch set 3 08/24/26, 20:43