Review 14.3 Merged

95412[BUGFIX] Fix null access when marking invalid stage items

Benjamin Kott CR +2 V +2 Easy +2 −2 updated 08/25/26, 11:12

Commit message

The form editor validates all form elements recursively and tries to
mark invalid form elements in the stage view. For elements on pages that
are not currently rendered, the stage DOM lookup returns null. This
caused a TypeError when the validation result was processed.

Add a null check before accessing the stage item element so invalid
elements on hidden pages are ignored gracefully and the editor remains
usable.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benjamin Kott commented on patch set 1 08/25/26, 10:56

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js
  2. Benjamin Kott uploaded patch set 2 08/25/26, 11:02

  3. Benjamin Kott marked it ready for review 08/25/26, 11:02

  4. core-ci voted on patch set 1 V -1 08/25/26, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107082

  5. core-ci voted on patch set 2 V +1 08/25/26, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107083

  6. Benjamin Kott voted on patch set 2 CR +2 V +2 08/25/26, 11:12

  7. Benjamin Kott merged patch set 3 08/25/26, 11:12