Review 14.3 Merged

95421[BUGFIX] Allow editors to localize root level records

Georg Ringer CR +2 V +2 Normal +128 −9 updated 08/26/26, 07:55

Commit message

Records on the root level (pid = 0) like sys_file_metadata could not be
localized by non-admin users: the wizard endpoints checked access with
BackendUtility::readPageAccess(), which can only succeed on pid = 0 for
admins.

For localizable tables which lift the root level restriction for
non-admins (security.ignoreRootLevelRestriction), the "tables_modify"
permission of the table itself is authoritative instead. This is
stricter than the check used for pid > 0, which only requires PAGE_SHOW
on the page and never looks at the table.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 34

  1. Georg Ringer commented on patch set 1 08/26/26, 07:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/26/26, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107127

  3. Georg Ringer voted on patch set 1 CR +2 V +2 08/26/26, 07:55

  4. Georg Ringer merged patch set 2 08/26/26, 07:55