Review main Merged

95423[BUGFIX] Add a placeholder to the multiselect filter field

Maike Kiebele CR +2 V +2 Easy +7 −3 updated 08/27/26, 16:32

Commit message

The filter input of the selectMultipleSideBySide FormEngine
element now carries a "Filter items" placeholder and matching
aria-label, making its purpose discoverable and announced
correctly by screen readers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Maike Kiebele uploaded patch set 1 08/26/26, 12:17

  2. core-ci voted on patch set 1 V +1 08/26/26, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107136

  3. Garvin Hicking commented on patch set 1 08/26/26, 22:15

    SelectMultipleSideBySideElement.php:216

    For fresh/new v14+ code I would prefer the new language domain syntax via `languageService->translate('labels.filter_items', 'core.core'` (untested, from memory with a yawny brain)
  4. Maike Kiebele uploaded patch set 2 V +1 08/27/26, 07:09

  5. Maike Kiebele commented on patch set 2 08/27/26, 07:11

    SelectMultipleSideBySideElement.php:216 Reply

    Done
  6. core-ci voted on patch set 2 V +1 08/27/26, 07:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107219

  7. Garvin Hicking commented on patch set 2 CR +1 V +1 08/27/26, 07:34

    Thanks! Works for me! 😊
  8. Georg Ringer voted on patch set 2 CR +2 V +2 08/27/26, 16:18

  9. Georg Ringer merged patch set 3 08/27/26, 16:32