Review main Merged

95429[TASK] Make the install tool null-safe

Benjamin Kott CR +2 V +2 Normal +99 −93 updated 11/19/26, 11:02

Commit message

Fifth step towards strictNullChecks. Only backend and form are left
after this one.

The install tool renders its own markup and then reads it straight
back, so the bulk of its errors were lookups declared as if they always
succeed. Where the module owns the template the call now says so, and
where it does not the value is guarded. The same holds for the data
attributes it writes and reads, which yield undefined for a missing
one.

A few declarations were simply untrue and are corrected rather than
asserted. The action queue of the core updater declared a finish
message and a follow-up action on every entry although the first
entries deliberately have neither, so both are optional now. The
progress bar helper took a target it then reassigned, which read as if
the parameter mattered; it uses a local instead. The extension
compatibility tester appended an uninstall button that is undefined for
a protected extension, which rendered the literal text "undefined"
below its message.

`AbstractInteractableModule` states the assumption once for all
modules: the modal body, content and footer exist for as long as the
module is interactable, so the three getters keep their non-null return
type instead of pushing the question to every caller.

The non-null assertions this step relies on are added with
strictNullChecks itself, as no-unnecessary-type-assertion reports every
such assertion until the option is enabled.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 39

Show 19 more files

Review log 1323

  1. Benjamin Kott uploaded patch set 1 08/26/26, 13:09

  2. Benjamin Kott marked it work in progress 08/26/26, 13:24

  3. core-ci voted on patch set 1 V +1 08/26/26, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107142

  4. Benjamin Kott uploaded patch set 2 V +1 10/15/26, 16:16

  5. core-ci voted on patch set 2 V +1 10/15/26, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111231

  6. Benjamin Kott updated the commit message in patch set 3 V +1 10/15/26, 21:02

  7. core-ci voted on patch set 3 V -1 10/15/26, 21:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111272

  8. Benjamin Kott rebased onto patch set 4 V -1 10/16/26, 07:45

  9. core-ci voted on patch set 4 V -1 10/16/26, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111320

  10. Benjamin Kott rebased onto patch set 5 V -1 10/16/26, 09:26

  11. core-ci voted on patch set 5 V +1 10/16/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/111335

  12. Benjamin Kott uploaded patch set 6 V +1 10/23/26, 14:49

  13. Benjamin Kott uploaded patch set 7 10/23/26, 15:42

  14. core-ci voted on patch set 6 V -1 10/23/26, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112327

  15. core-ci voted on patch set 7 V -1 10/23/26, 16:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112347

  16. Benjamin Kott uploaded patch set 8 V -1 11/18/26, 10:59

  17. core-ci voted on patch set 8 V +1 11/18/26, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114859

  18. Benjamin Kott uploaded patch set 9 V +1 11/19/26, 08:37

  19. core-ci voted on patch set 9 V -1 11/19/26, 08:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114974

  20. core-ci voted on patch set 9 V +1 11/19/26, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114974

  21. Benni Mack voted on patch set 9 CR +1 V +1 11/19/26, 09:32

  22. Benjamin Kott voted on patch set 9 CR +2 V +2 11/19/26, 11:02

  23. Benjamin Kott merged patch set 10 11/19/26, 11:02