#111505Make the install tool null-safe
Description
The JavaScript of the install tool reads values that can be missing at runtime without a check. It renders its own markup and reads it straight back, so most lookups of templates, containers and buttons are declared as if they always succeed, and the dataset attributes it writes and reads are used as strings although a missing one yields undefined.
Some declarations are untrue as well. The action queue of the core updater declares a finish message and a follow-up action on every entry although the first entries have neither. The extension compatibility tester appends an uninstall button that is undefined for a protected extension, which renders the literal text “undefined” below its message.
These places should get a guard or a fallback where the value can really be missing, and a correct declaration where it was wrong, so install compiles under strictNullChecks.
Reviews 2
History 14
-
Gerrit Code Review pushed patch set 9 for main to change 95429 status
NewUnder Review <span data-processor="relativetime" data-value="2026-11-19T08:37:51+00:00" > 11/19/26, 08:37 </span> -
Gerrit Code Review pushed patch set 1 for 14.3 to change 97839 <span data-processor="relativetime" data-value="2026-11-19T10:11:48+00:00" > 11/19/26, 10:11 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 97839 <span data-processor="relativetime" data-value="2026-11-19T10:16:27+00:00" > 11/19/26, 10:16 </span>
-
Benjamin Kott commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-19T11:05:13+00:00" > 11/19/26, 11:05 </span>
Applied in changeset commit:7ea3a10416cde3a20267a5fd3d4b29908a63d528.