Review 14.3 Merged

95439[BUGFIX] Let stdWrap override apply the value "0"

Benjamin Kott CR +2 V +2 Easy +38 −2 updated 08/26/26, 23:24

Commit message

The stdWrap property "override" replaced the current content whenever
the configured value was truthy after trimming. In PHP the string "0"
is falsy, so an override evaluating to a single zero silently kept the
previous content instead of replacing it. TypoScript delivers every
value as a string, which made "0" the one scalar an override could not
produce, for example when the value came from a condition or a nested
stdWrap.

The check now compares the trimmed value against an empty string, so
only an unset, empty or whitespace-only value leaves the content
untouched, while "0" overrides like any other value.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Benjamin Kott commented on patch set 1 08/26/26, 21:57

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 08/26/26, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107193

  3. Benjamin Kott voted on patch set 1 CR +2 V +2 08/26/26, 23:24

  4. Benjamin Kott merged patch set 2 08/26/26, 23:24