95461[TASK] Allow record objects for record icons
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Wouter Wolters +1
-
Verified V +2 Done
- Benni Mack +2
- Wouter Wolters +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/core/Classes/Imaging/IconFactory.php+15 −1
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php2+29 −6
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-108813-IconForRecordSupportsRecordObjects.rstnew+58 −0
- typo3/sysext/core/Tests/Functional/Imaging/Fixtures/tt_content.csvnew+3 −0
- typo3/sysext/core/Tests/Functional/Imaging/IconFactoryTest.php+32 −0
- typo3/sysext/core/Tests/Functional/ViewHelpers/IconForRecordViewHelperTest.php+60 −2
Review log 1316
-
Georg Ringer uploaded patch set 1 08/27/26, 20:25
-
Georg Ringer commented on patch set 1 08/27/26, 20:25
This change is ready for review. -
Benni Mack commented on patch set 1 08/27/26, 20:27
IconForRecordViewHelper.php:69I'd love if we can have RecordInterface into "getIconForRecord" as well? -
core-ci voted on patch set 1 V +1 08/27/26, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107295
-
Georg Ringer uploaded patch set 2
V +108/27/26, 20:39 -
Georg Ringer commented on patch set 2 08/27/26, 20:39
IconForRecordViewHelper.php:69ReplyDone -
core-ci voted on patch set 2 V +1 08/27/26, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107296
-
Wouter Wolters voted on patch set 2 CR +1 08/27/26, 20:48
-
Benni Mack commented on patch set 2 CR -1 09/02/26, 06:30
will work on it -
Benni Mack uploaded patch set 3
CR +1V +109/02/26, 15:10 -
core-ci voted on patch set 3 V +1 09/02/26, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107646
-
Wouter Wolters voted on patch set 3 CR +1 V +1 09/02/26, 15:56
-
Benni Mack commented on patch set 3 09/02/26, 15:58
Reply
Done -
Benni Mack voted on patch set 3 CR +1 V +1 09/02/26, 15:59
-
Benni Mack voted on patch set 3 CR +2 V +2 09/02/26, 16:06
-
Benni Mack merged patch set 4 09/02/26, 16:06