Review main Merged

95461[TASK] Allow record objects for record icons

Georg Ringer CR +2 V +2 Normal +197 −9 updated 09/02/26, 16:06

Commit message

IconFactory->getIconForRecord() and the row argument of the Fluid
ViewHelper <core:iconForRecord> only accepted a plain database row
array. Code already working with record objects had to rebuild an
array just to render an icon.

IconFactory->getIconForRecordObject() now renders the icon for an
object implementing RecordInterface. The table is taken from the
record itself, the raw database row is used, so status overlays for
disabled or scheduled records are rendered the same way as for a
plain array.

The ViewHelper gained an interchangeable argument "record": both
"row" and "record" accept a row array as well as a record object,
exactly one of them must be given. The argument "table" is only
required for row arrays and is not evaluated for record objects.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Wouter Wolters +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1316

  1. Georg Ringer uploaded patch set 1 08/27/26, 20:25

  2. Georg Ringer commented on patch set 1 08/27/26, 20:25

    This change is ready for review.
  3. Benni Mack commented on patch set 1 08/27/26, 20:27

    IconForRecordViewHelper.php:69

    I'd love if we can have RecordInterface into "getIconForRecord" as well?
  4. core-ci voted on patch set 1 V +1 08/27/26, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107295

  5. Georg Ringer uploaded patch set 2 V +1 08/27/26, 20:39

  6. Georg Ringer commented on patch set 2 08/27/26, 20:39

    IconForRecordViewHelper.php:69 Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/27/26, 20:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107296

  8. Wouter Wolters voted on patch set 2 CR +1 08/27/26, 20:48

  9. Benni Mack commented on patch set 2 CR -1 09/02/26, 06:30

    will work on it
  10. Benni Mack uploaded patch set 3 CR +1 V +1 09/02/26, 15:10

  11. core-ci voted on patch set 3 V +1 09/02/26, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107646

  12. Wouter Wolters voted on patch set 3 CR +1 V +1 09/02/26, 15:56

  13. Benni Mack commented on patch set 3 09/02/26, 15:58

    Reply

    Done
  14. Benni Mack voted on patch set 3 CR +1 V +1 09/02/26, 15:59

  15. Benni Mack voted on patch set 3 CR +2 V +2 09/02/26, 16:06

  16. Benni Mack merged patch set 4 09/02/26, 16:06