#108813Core IconForRecord ViewHelper should support RecordInterface
Description
Right now this ViewHelper only works with raw arrays. But as we are now moving more and more towards Records it would be nice to add RecordInterface support.
Current workaround: <core:iconforrecord table="tt_content" row="{CType: item.CType}"></core:iconforrecord>
Desired: <core:iconforrecord table="{record.mainType}" row="{record}"></core:iconforrecord>
Reviews 2
History 712
-
Nikita Hovratov changed subject
Core IconForRecord should support RecordInterfaceCore IconForRecord ViewHelper should support RecordInterface <span data-processor="relativetime" data-value="2026-01-30T13:38:54+00:00" > 01/30/26, 13:38 </span> -
Garvin Hicking commented <span data-processor="relativetime" data-value="2026-01-30T14:06:57+00:00" > 01/30/26, 14:06 </span>
-
Nikita Hovratov commented <span data-processor="relativetime" data-value="2026-01-30T17:07:29+00:00" > 01/30/26, 17:07 </span>
Garvin Hicking wrote in #note-2:
> Maybe use “record” then instead of “row” for distinction?Hm, unsure. In CObject VH we can put an array or RecordInterface into “data”. In the end Record holds the db row anyway, but we can’t access it in Fluid.
For the user in Fluid it is easier not to guess if he has an array or Record at hand. Especially for integrators this distinction is confusing. So I would relax the parameter input strictness for the sake of fool-prove usage.> Are you on this?
No, if you want you can tackle it :) -
Garvin Hicking commented and changed status
NewAccepted assigned to Garvin Hicking <span data-processor="relativetime" data-value="2026-01-30T17:16:46+00:00" > 01/30/26, 17:16 </span>Fair point. :)
I’ll check this out, but it will take a couple of days. If anyone else reads this (…haha) go ahead, I’ll review ;)
-
Benni Mack changed Sprint Focus On Location Sprint <span data-processor="relativetime" data-value="2026-08-06T16:02:45+00:00" > 08/06/26, 16:02 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 95461 status
AcceptedUnder Review <span data-processor="relativetime" data-value="2026-08-27T20:25:18+00:00" > 08/27/26, 20:25 </span> -
Gerrit Code Review pushed patch set 2 for main to change 95461 <span data-processor="relativetime" data-value="2026-08-27T20:39:08+00:00" > 08/27/26, 20:39 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 95461 <span data-processor="relativetime" data-value="2026-09-02T15:10:43+00:00" > 09/02/26, 15:10 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 95570 <span data-processor="relativetime" data-value="2026-09-02T15:59:23+00:00" > 09/02/26, 15:59 </span>
-
Georg Ringer commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-02T16:10:09+00:00" > 09/02/26, 16:10 </span>Applied in changeset commit:31c1887202ffa18defc49d2b328f0e62f7ebfcf5.
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 95570 status
ResolvedUnder Review <span data-processor="relativetime" data-value="2026-09-02T16:56:57+00:00" > 09/02/26, 16:56 </span> -
Georg Ringer commented and changed status
Under ReviewResolved <span data-processor="relativetime" data-value="2026-09-02T17:15:08+00:00" > 09/02/26, 17:15 </span>Applied in changeset commit:f3d696bfc664256be7867e4b97d244fb9b610b0b.
Maybe use “record” then instead of “row” for distinction?
Are you on this?