Review 14.3 Merged

95516[BUGFIX] Restrict allowed characters of pages cache tags

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 09/01/26, 12:20

Commit message

The field `pages.cache_tags` accepted arbitrary input, while the
caching framework only allows `[a-zA-Z0-9_%-&]` per tag. A single
tag containing e.g. a space made `VariableFrontend::set()` throw an
`InvalidArgumentException`, which broke the frontend of that page
on the next cache write.

The field is now evaluated with `trim,is_in`, so invalid characters
are stripped in FormEngine as well as in DataHandler. Writing a
list as "News, Blog" keeps working, since the stored value is
exploded and trimmed per tag.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 09/01/26, 12:01

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/01/26, 12:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107483

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 09/01/26, 12:20

  4. Stefan Bürk merged patch set 2 09/01/26, 12:20