Review 14.3 Merged

95535[BUGFIX] Ignore enable fields in Extbase overlays

Stefan Bürk CR +2 V +2 Normal +223 −6 updated 09/02/26, 09:00

Commit message

The Extbase query setting setIgnoreEnableFields() switched off the
enable fields for the records a query selects, but not for the
translations those records are overlaid with. PageRepository fetches the
overlay with a FrontendRestrictionContainer built from the visibility
aspect of the context it was given, and Extbase never told that context
about the query settings. A hidden translation was therefore never
found: with languageOverlayMode hideNonTranslated the record was dropped
from the result while count() still counted it, and with the default
overlay mode the untranslated default language record was returned
instead.

Extbase now mirrors ignoreEnableFields and enableFieldsToBeIgnored into
the visibility aspect of the cloned context the overlay is done with, so
hidden and time-restricted translations are found as well. Frontend user
group restrictions are not part of that aspect and stay applied to
translations.

An existing test documented the previous behaviour as buggy and is
corrected along with it.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 3

Files 5

Review log 46

  1. Stefan Bürk commented on patch set 1 09/01/26, 20:58

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/01/26, 21:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107528

  3. Stefan Bürk uploaded patch set 2 V -1 09/02/26, 08:49

  4. core-ci voted on patch set 2 V +1 09/02/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107583

  5. Stefan Bürk voted on patch set 2 CR +2 V +2 09/02/26, 09:00

  6. Stefan Bürk merged patch set 3 09/02/26, 09:00