Review 14.3 Merged

95549[BUGFIX] Skip foreign table query for transOrigPointerField on default language

Benni Mack CR +2 V +2 Easy +13 −1 updated 09/02/26, 07:57

Commit message

The transOrigPointerField (e.g. l18n_parent) is configured with a
displayCond that hides it for records in the default language
(sys_language_uid <= 0). However, TcaSelectItems runs before
EvaluateDisplayConditions and unconditionally calls
addItemsFromForeignTable(), which queries all records on the same
PID. On pages with large numbers of content records this causes
significant performance degradation.

Skip the addItemsFromForeignTable() call when the field being
processed is the transOrigPointerField and the current record
belongs to the default or "all languages" language, as the field
will never be displayed in that case.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 09/02/26, 07:49

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/02/26, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107580

  3. Benni Mack voted on patch set 1 CR +2 V +2 09/02/26, 07:57

  4. Benni Mack merged patch set 2 09/02/26, 07:57