Review 14.3 Merged

95567[BUGFIX] Prevent attaching non-object values in ObjectStorageConverter

Georg Ringer CR +2 V +2 Normal +225 −4 updated 09/02/26, 14:31

Commit message

Ensure that only objects are attached to ObjectStorage by adding an
explicit is_object check when iterating over $convertedChildProperties
in the ObjectStorageConverter. This avoids potential runtime errors
when $convertedChildProperties may contain non-object entries.

This issue became evident when processing data via
PersistentObjectConverter, where non-object values could be present in
the child properties, in contrast to handling via ObjectConverter. To
ensure both converters behave consistently and handle edge cases
correctly, extended functional tests have been implemented for both
PersistentObjectConverter and ObjectConverter.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Georg Ringer commented on patch set 1 09/02/26, 14:21

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/02/26, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107641

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/02/26, 14:31

  4. Georg Ringer merged patch set 2 09/02/26, 14:31