Review 14.3 Merged

95573[BUGFIX] Catch errors if ini_set is not allowed

Benni Mack CR +2 V +2 Normal +212 −10 updated 09/02/26, 21:09

Commit message

If the function ini_set is part of the setting
`disable_functions` the errors must be caught to
allow a running setup.

Most of the session settings of the install tool are
best practice and it keeps working without them. Two
of them are not: session.cookie_secure keeps the
session cookie off plain HTTP, session.cookie_httponly
keeps it away from JavaScript. Both are read back with
ini_get now, and an error is logged if they are not in
effect, so a silently degraded session does not go
unnoticed.

See https://www.php.net/manual/en/ini.core.php#ini.disable-functions

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Benni Mack commented on patch set 1 09/02/26, 16:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/02/26, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107653

  3. Benni Mack uploaded patch set 2 V -1 09/02/26, 20:41

  4. core-ci voted on patch set 2 V +1 09/02/26, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107679

  5. Benni Mack voted on patch set 2 CR +2 V +2 09/02/26, 21:09

  6. Benni Mack merged patch set 3 09/02/26, 21:09