Review 14.3 Merged

95582[BUGFIX] Import page translations onto their parent page

Benjamin Kott CR +2 V +2 Normal +97 −1 updated 09/02/26, 21:59

Commit message

The export appends page translations to the exported page tree as top
level nodes, purely to mark them as being part of that tree. The import
reads the same section as a real tree and reverses each level, so a
translation was written before the page it belongs to had been assigned
its new ID. The parent lookup missed and the translation was created on
the import target instead of next to its default language page.

The pages are now ordered so that every page is written after its
parent page. The file format stays untouched, so already exported
files import correctly as well.

A functional import test for a multilingual page tree is added, which
was missing so far and let the export and import sides drift apart.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Benjamin Kott commented on patch set 1 09/02/26, 21:20

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/02/26, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107684

  3. Benni Mack commented on patch set 2 V -1 09/02/26, 21:51

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 09/02/26, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107688

  5. Benjamin Kott voted on patch set 2 CR +2 V +2 09/02/26, 21:59

  6. Benjamin Kott merged patch set 3 09/02/26, 21:59