Review 14.3 Merged

95589[BUGFIX] Save unsaved parent before following addRecord wizard

Oli Bartsch CR +2 V +2 Hard +346 −6 updated 09/03/26, 08:52

Commit message

Clicking the "+" (fieldControl.addRecord) control on a field
belonging to a record that is itself still new (e.g. an unsaved
IRRE/inline child) silently discarded that unsaved record and never
linked the newly created one back to it, since Wizard/AddController
has no way to resolve a "NEW..." placeholder uid.

A new "_savedokaddrecord" FormAction saves the parent first, then
redirects into the add-record wizard using the real, persisted uid.
A confirmation dialog offers to save, discard, or keep editing when
the parent has unsaved changes. The redirect back to the edited
document once the wizard is done is computed server-side from the
now-persisted editconf, not from a client-supplied returnUrl.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 34

  1. Oli Bartsch uploaded patch set 1 09/03/26, 07:00

  2. core-ci voted on patch set 1 V +1 09/03/26, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107722

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 09/03/26, 08:52

  4. Oli Bartsch merged patch set 2 09/03/26, 08:52