Review 14.3 Merged

95609[TASK] Handle client-side errors of workspace dispatcher

Georg Ringer CR +2 V +2 Normal +148 −59 updated 09/03/26, 19:20

Commit message

Exceptions of the workspace ajax endpoints are now reported to the
client, which turns them into error notifications instead of failing
silently.

Server side:
* Both "workspace_dispatch" and "workspace_preview" share one call
  stack processing with identical error handling
* A response is always a list with one entry per call, carrying
  either a "result" or an "error" property
* A failing call no longer aborts the stack, results calculated
  already are kept, HTTP status 500 signals a partial failure
* Handled exceptions never reach the global exception handler and
  are therefore logged explicitly

Client side:
* sendRemoteRequest() keeps the rejection up after notifying, so
  callers do not continue with an error payload
* Failures without server side details, like an unreachable server
  or an error page that is no JSON, get a generic message
* Notification texts are taken from locallang.xlf

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Georg Ringer commented on patch set 1 09/03/26, 17:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/03/26, 17:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107766

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/03/26, 19:20

  4. Georg Ringer merged patch set 2 09/03/26, 19:20