Review 14.3 Merged

95685[BUGFIX] Ensure numeric site identifiers stay strings

Georg Ringer CR +2 V +2 Easy +34 −0 updated 09/07/26, 19:08

Commit message

A site directory consisting of digits only, e.g.
config/sites/123, made every request fail with a
TypeError, because Site::__construct() expects
a string identifier.

SiteConfiguration::getAllResolvedSiteData() does
cast the identifier to string, but uses it as an
array key afterwards, where PHP converts a numeric
string back to int. The cast is therefore repeated
in resolveAllExistingSites(), directly where the
Site object is created.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 09/07/26, 18:23

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/07/26, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108021

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/07/26, 19:08

  4. Georg Ringer merged patch set 2 09/07/26, 19:08