Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
95723[!!!][TASK] Make VisibilityAspect constructor private
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/95723/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/95723/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Relation chain 2
-
95723 [!!!][TASK] Make VisibilityAspect constructor private This change
-
main
95681[TASK] Add immutable with-methods to VisibilityAspect
The chain has patch set 3 of 6, the changes above it need a rebase.
Issues 1
Files 10
- typo3/sysext/core/Classes/Context/VisibilityAspect.php+1 −1
- typo3/sysext/core/Documentation/Changelog/15.0/Breaking-110647-VisibilityAspectConstructor.rstnew+95 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Restriction/FrontendRestrictionContainerTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Domain/Access/RecordAccessVoterTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+1 −1
- typo3/sysext/core/Tests/Functional/TypoScript/IncludeTree/SysTemplateRepositoryTest.php+4 −4
- typo3/sysext/core/Tests/Functional/Utility/RootlineUtilityTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Context/VisibilityAspectTest.php+29 −7
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstructorArgumentMatcher.php+1 −0
Review log 12
-
Matthias Vogel uploaded patch set 1 09/08/26, 09:21
-
core-ci voted on patch set 1 V +1 09/08/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108077