Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale Breaking

95723[!!!][TASK] Make VisibilityAspect constructor private

Matthias Vogel CR 0 V 0 Normal +140 −22 updated 09/08/26, 09:33

Commit message

The VisibilityAspect constructor was deprecated in TYPO3 v14 in favor
of obtaining the existing aspect and using its immutable with-methods.

Make the constructor private to prevent direct instantiation and ensure
visibility changes preserve all existing aspect configuration.

Use the existing VisibilityAspect from the Context and its with-methods
instead of creating a new instance.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/95723/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/23/95723/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 95723 [!!!][TASK] Make VisibilityAspect constructor private This change

  2. main 95681[TASK] Add immutable with-methods to VisibilityAspect This change is based on it Merged Matthias Vogel CR +2 V +2 → 14.3 Normal +133 −31

    The chain has patch set 3 of 6, the changes above it need a rebase.

Issues 1

Files 10

Review log 12

  1. Matthias Vogel uploaded patch set 1 09/08/26, 09:21

  2. core-ci voted on patch set 1 V +1 09/08/26, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108077