Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Stale

95726[WIP][TASK] Inject services into the maintenance controller

Stefan Bürk CR 0 V 0 Normal +105 −43 updated 09/08/26, 10:29

Commit message

The maintenance controller of the install tool built two of
its services with GeneralUtility::makeInstance() and carried
the container of a late boot in a local variable in fourteen
places.

Both makeInstance() calls are gone. The opcode cache service
is provided by the failsafe container and is injected, and the
password policy validator is built with its arguments in the
service provider, which also drops the mutable property the
constructor filled.

The container variables are gone as well. An action that needs
ext_localconf.php and TCA calls loadExtLocalconfDatabase() as
a statement and resolves what it needs from the container of
that boot, every other action resolves in place.

The database, schema, language pack and FAL services stay
resolved from that container instead of being injected. The
install tool is dispatched from the failsafe container, which
deliberately does not provide them and refuses the connection
pool outright, so injecting them would boot the full container
for every maintenance request - which is what the failsafe
dispatch exists to avoid.

The functional test covers the two injected services and the
reference index action, which resolves from the booted
container, next to the database analyzer actions it covered
already.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/95726/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/26/95726/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. 95726 [WIP][TASK] Inject services into the maintenance controller This change

  2. main 95696[TASK] Stabilize the install tool presets e2e test This change is based on it Merged Stefan Bürk CR +2 V +2 → 14.3 Easy +33 −17

    The chain has patch set 2 of 3, the changes above it need a rebase.

Issues 3

Files 3

Review log 12

  1. Stefan Bürk uploaded patch set 1 09/08/26, 10:21

  2. core-ci voted on patch set 1 V +1 09/08/26, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108082