Review 14.3 Merged

95734[TASK] Use first class callable closures instead of array callables

Benni Mack CR +2 V +2 Normal +58 −34 updated 09/09/26, 05:41

Commit message

Array callables such as [$this, 'method'] are replaced with the first
class callable syntax $this->method(...), which is type safe and can
be resolved by static analysis.

The failsafe container test keeps the array notation covered as well,
since service providers may use either notation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 28

Show 8 more files

Review log 711

  1. Benni Mack commented on patch set 1 09/08/26, 18:04

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php
  2. Benni Mack commented on patch set 2 09/08/26, 18:05

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/08/26, 18:05

  4. core-ci voted on patch set 2 V -1 09/08/26, 18:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108109

  5. core-ci voted on patch set 1 V -1 09/08/26, 18:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108108

  6. Wouter Wolters uploaded patch set 3 V -1 09/08/26, 21:14

  7. core-ci voted on patch set 3 V -1 09/08/26, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108121

  8. Wouter Wolters uploaded patch set 4 V -1 09/08/26, 21:27

  9. core-ci voted on patch set 4 V +1 09/08/26, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108124

  10. Benni Mack voted on patch set 4 CR +2 V +2 09/09/26, 05:41

  11. Benni Mack merged patch set 5 09/09/26, 05:41