Review main Merged

95762[BUGFIX] Disable synced select fields in translations

Maike Kiebele CR +2 V +2 Easy +1 −0 updated 10/23/26, 09:06

Commit message

The localization state selector already disables a field on load
once its state is "Value of default language". It locates that
field via the "data-formengine-input-name" attribute.

SelectSingleElement never rendered this attribute on its <select>,
so the existing disable logic found nothing and the dropdown stayed
editable. Render the attribute like other form elements already do.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Adrian Widmer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Adrian Widmer +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Maike Kiebele uploaded patch set 1 09/10/26, 13:27

  2. core-ci voted on patch set 1 V +1 09/10/26, 13:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108265

  3. Adrian Widmer commented on patch set 1 CR +1 V +1 09/10/26, 15:03

    Tested and approved
  4. Benni Mack voted on patch set 1 CR +2 V +2 10/23/26, 09:06

  5. Benni Mack merged patch set 2 10/23/26, 09:06