Review 14.3 Merged

95780[TASK] Add immutable with-methods to VisibilityAspect

Garvin Hicking CR +2 V +2 Normal +133 −31 updated 09/12/26, 00:21

Commit message

Recreating a VisibilityAspect to change one flag requires callers
to copy every constructor argument. Newly added options can then
be lost silently, as illustrated by #110322.

Add with-methods for the existing visibility flags to preserve
unrelated settings and provide an immutable API for adjusting an
existing VisibilityAspect.

Deprecation of constructor might happen later.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 14

Review log 57

  1. Garvin Hicking commented on patch set 1 09/12/26, 00:04

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php * typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php
  2. core-ci voted on patch set 1 V -1 09/12/26, 00:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108372

  3. Garvin Hicking commented on patch set 2 V -1 09/12/26, 00:10

    Published edit on patch set 1.
  4. Garvin Hicking marked it ready for review 09/12/26, 00:10

  5. core-ci voted on patch set 2 V +1 09/12/26, 00:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108373

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 09/12/26, 00:21

  7. Garvin Hicking merged patch set 3 09/12/26, 00:21