95780[TASK] Add immutable with-methods to VisibilityAspect
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 2
Files 14
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+8 −2
- typo3/sysext/backend/Classes/Http/Application.php+7 −1
- typo3/sysext/backend/Classes/Routing/PreviewUriBuilder.php+6 −1
- typo3/sysext/core/Classes/Console/CommandApplication.php+7 −1
- typo3/sysext/core/Classes/Context/Context.php+1 −1
- typo3/sysext/core/Classes/Context/VisibilityAspect.php+50 −0
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+1 −1
- typo3/sysext/core/Tests/Unit/Context/VisibilityAspectTest.php+28 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+9 −7
- typo3/sysext/frontend/Classes/Http/Application.php+1 −1
- typo3/sysext/frontend/Classes/Middleware/PreviewSimulator.php+1 −3
- typo3/sysext/install/Classes/Http/Application.php+8 −1
- typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php+4 −6
- typo3/sysext/tstemplate/Classes/Controller/AbstractTemplateModuleController.php+2 −6
Review log 57
-
Garvin Hicking commented on patch set 1 09/12/26, 00:04
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Classes/Domain/Repository/PageRepository.php * typo3/sysext/redirects/Classes/EventListener/AddPageTypeZeroSource.php -
core-ci voted on patch set 1 V -1 09/12/26, 00:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108372
-
Garvin Hicking commented on patch set 2
V -109/12/26, 00:10Published edit on patch set 1. -
Garvin Hicking marked it ready for review 09/12/26, 00:10
-
core-ci voted on patch set 2 V +1 09/12/26, 00:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108373
-
Garvin Hicking voted on patch set 2 CR +2 V +2 09/12/26, 00:21
-
Garvin Hicking merged patch set 3 09/12/26, 00:21