Review main Ready for review

95821[BUGFIX] Use icons for local media files

Wouter Wolters CR +1 V +1 Normal +54 −5 updated 11/13/26, 19:11

Commit message

Local audio and video files are treated as image previews in the
filelist tile view. Failed image processing then creates an unusable
image element that points to the original media file.

Limit previews to images and registered online media files. Other media
files now render their mimetype icon.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/95821/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/21/95821/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Riccardo De Contardi +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 4

Review log 67

  1. Wouter Wolters uploaded patch set 1 09/14/26, 20:12

  2. Wouter Wolters marked it ready for review 09/14/26, 20:14

  3. core-ci voted on patch set 1 V +1 09/14/26, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108553

  4. Riccardo De Contardi commented on patch set 1 V +1 09/16/26, 09:12

    tested on latest main with both an .mp3 file and an .mp4 file. In both cases the svg icon for that filetypes have been used.
  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/22/26, 19:54

  6. Benni Mack commented on patch set 1 09/23/26, 12:59

    FileList.php:359 Unresolved

    I've seen onlinemediahelper being used for a lot more than "just" online media, but like an integration of third-party DAM. I would need to recheck this on one setup (but I'm only able to do this later) - won't block this though
  7. Benni Mack commented on patch set 1 11/13/26, 19:11

    Limiting previews to images and online media means a custom processor can no longer provide previews for local videos (see #105945). Could we instead fall back to the icon only when processing returns the placeholder?