Review 14.3 Merged

95843[BUGFIX] Use Popover API for notifications

Benjamin Franzke CR +2 V +2 Normal +56 −20 updated 09/15/26, 08:24

Commit message

Using Popover API provides builtin accessibility
features and avoids manual z-index coordination.
and allows to show above modals (with a small constraint [1]).

This will allow to avoid having to add custom
success notifications in modal windows, as required
for #109130 and ensure notifications from slug updates
are visible when using the contextual editing panel.

[1] In order to make popovers interactive, when a `<dialog>` is
    opened – see https://github.com/whatwg/html/issues/9936 – the
    alert container is mounted into the topmost `<dialog>` element.
    This is the only known workaround to a limitation of the `<dialog>`
    specification which makes all elements outside the topmost
    `<dialog>` inert. Also see:
    https://github.com/whatwg/html/issues/9936#issuecomment-2905180369

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 3

Files 6

Review log 34

  1. Benjamin Franzke commented on patch set 1 09/15/26, 07:48

    Cherry Picked from branch main.
  2. Benjamin Franzke voted on patch set 1 CR +2 V +2 09/15/26, 07:52

  3. core-ci voted on patch set 1 V +1 09/15/26, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108589

  4. Benjamin Franzke merged patch set 2 09/15/26, 08:24