Review main Merged

95882[TASK] Clean up user settings normalization test

Wouter Wolters CR +2 V +2 Easy +6 −25 updated 09/23/26, 18:12

Commit message

The normalization migration test still refers to a pending database
connection change that has already been merged. It also creates Doctrine
JSON type objects where the JSON type name is sufficient.

Remove the obsolete comments, use Types::JSON directly, and clarify the
affected test method name while preserving the double-encoded fixtures.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Wouter Wolters uploaded patch set 1 09/16/26, 17:04

  2. core-ci voted on patch set 1 V +1 09/16/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108706

  3. Oliver Klee voted on patch set 1 CR +1 V +1 09/16/26, 17:24

  4. Benni Mack voted on patch set 1 CR +2 V +2 09/23/26, 18:12

  5. Benni Mack merged patch set 2 09/23/26, 18:12