Issue Task Resolved

#110725Clean up user settings normalization migration test

Wouter Wolters 09/16/26, 17:02 updated 09/23/26, 18:15

Description

UserSettingsNormalizationMigrationTest still contains TODO comments and references to Gerrit change 89293, although that change has already been merged.

The test also creates Doctrine JSON type objects explicitly, while the JSON type name can now be passed directly. Additionally, one test method has a duplicated When and does
not clearly describe its expected result.

Remove the obsolete comments, use Types::JSON directly, and correct the test method name. The intentionally double-encoded fixtures must remain unchanged because they represent
the data handled by the migration.

Reviews 2

History 13

  1. Wouter Wolters commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-09-23T18:15:15+00:00" > 09/23/26, 18:15 </span>

    Applied in changeset commit:3b1e1aa8c7a7feb2c4a838f5756a06392d45348a.