95892[TASK] Stop swallowing exceptions in functional tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1114
-
Wouter Wolters uploaded patch set 1 09/16/26, 20:20
-
core-ci voted on patch set 1 V +1 09/16/26, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108720
-
Simon Schaufelberger voted on patch set 1 CR +1 V +1 09/16/26, 20:33
-
Oliver Klee commented on patch set 1 09/16/26, 20:43
-
Wouter Wolters commented on patch set 1 09/16/26, 20:53
PagesAndTtContentWithImagesInEmptyDatabaseTest.php:155ReplyDone -
Wouter Wolters uploaded patch set 2
CR +1V +109/16/26, 20:54 -
core-ci voted on patch set 2 V -1 09/16/26, 21:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108725
-
Wouter Wolters uploaded patch set 3
V -109/16/26, 21:27 -
Wouter Wolters commented on patch set 3 09/16/26, 21:28
PagesAndTtContentWithImagesInEmptyDatabaseTest.php:155ReplyWe can't use these functions because we catch the exception to check other things as well after the code has thrown an exception. Using the other functions the code stops directly after importData throwed the exception. -
core-ci voted on patch set 3 V +1 09/16/26, 21:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108731
-
Simon Schaufelberger voted on patch set 3 CR +1 V +1 09/16/26, 22:44
-
Benni Mack voted on patch set 3 CR +1 V +1 09/17/26, 05:34
-
Benni Mack voted on patch set 3 CR +2 V +2 09/17/26, 05:55
-
Benni Mack merged patch set 4 09/17/26, 05:55
PagesAndTtContentWithImagesInEmptyDatabaseTest.php:155