#110730Stop functional tests from swallowing unexpected exceptions
Description
Two import tests catch and ignore every exception so they can continue checking the import error log. The Redis compression test similarly ignores decompression exceptions and
suppresses warnings.
These broad catches can hide unrelated regressions and allow tests to continue after unexpected failures.
Assert the expected ImportFailedException, including its class, code, and message, in the import tests. Allow other import exceptions and Redis decompression failures to
propagate normally.
Reviews 2
History 15
-
Gerrit Code Review pushed patch set 1 for main to change 95892 status
NewUnder Review <span data-processor="relativetime" data-value="2026-09-16T20:20:50+00:00" > 09/16/26, 20:20 </span> -
Gerrit Code Review pushed patch set 2 for main to change 95892 <span data-processor="relativetime" data-value="2026-09-16T20:54:08+00:00" > 09/16/26, 20:54 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 95892 <span data-processor="relativetime" data-value="2026-09-16T21:27:34+00:00" > 09/16/26, 21:27 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 95897 <span data-processor="relativetime" data-value="2026-09-17T05:36:14+00:00" > 09/17/26, 05:36 </span>
-
Wouter Wolters commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-09-17T06:00:13+00:00" > 09/17/26, 06:00 </span>
Applied in changeset commit:87eb3fc89e51bfc9a2eb7db8c20552142c39643e.