Review 14.3 Merged

95909[BUGFIX] Quote container binary check in runTests.sh

Stefan Bürk CR +2 V +2 Easy +1 −1 updated 09/18/26, 08:59

Commit message

The condition selecting the docker "--user" workaround leaves both
"$(uname)" and "${CONTAINER_BIN}" unquoted. With neither podman nor
docker installed, "${CONTAINER_BIN}" expands to nothing and the test
aborts with "[: =: unary operator expected" before the intended hint
"Selected container environment ... not found" is printed.

Quoting both expansions drops that stray message and resolves the
shellcheck finding SC2046 reported for this line.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 09/18/26, 08:45

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/18/26, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108796

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 09/18/26, 08:59

  4. Stefan Bürk merged patch set 2 09/18/26, 08:59