Review 14.3 Merged

95925[TASK] Correct argument order in unit test assertions

Georg Ringer CR +2 V +2 Easy +4 −4 updated 09/19/26, 09:22

Commit message

Several unit tests pass actual values before expected values to PHPUnit
assertions. This produces misleading failure messages and diffs.

Pass expected values first and actual results second in the affected
assertions.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Georg Ringer commented on patch set 1 09/19/26, 09:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/19/26, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108841

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/19/26, 09:22

  4. Georg Ringer merged patch set 2 09/19/26, 09:22