Review 14.3 Merged

95973[BUGFIX] Tolerate an unresolvable itemsProcFunc when saving

Oli Bartsch CR +2 V +2 Normal +193 −3 updated 09/23/26, 08:39

Commit message

DataHandler composes the items of a check and of a radio field itself
before it accepts a value for them. Both did so without guarding what
that can cost.

`checkValueForCheck()` reads the declared items as optional and hands
them on as required one line later, so a field leaving all its boxes
to a processor ends the save with a TypeError.

Neither method catches `ItemsProcessorExecutionFailedException`, which
`ItemProcessingService` throws for anything a processor raises. The
editing form has caught it all along.

A processor that cannot run now leaves the boxes the field declares
for a checkbox, and no further item to compare against for a radio.

Defaults are applied for every column of a new record, so one such
field made every new record of its table fail, not only records the
field was submitted with.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 5

Review log 46

  1. Oli Bartsch commented on patch set 1 09/22/26, 06:07

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/22/26, 06:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108969

  3. Oli Bartsch uploaded patch set 2 V -1 09/23/26, 08:18

  4. core-ci voted on patch set 2 V +1 09/23/26, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109035

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 09/23/26, 08:39

  6. Oli Bartsch merged patch set 3 09/23/26, 08:39