Review 14.3 Merged

95984[TASK] Streamline temporary file cleanup in unit tests

Benni Mack CR +2 V +2 Normal +42 −76 updated 09/23/26, 12:29

Commit message

Several unit tests remove temporary artifacts inline or implement
custom tearDown methods. This duplicates cleanup logic.

Register created files and directories in the inherited
testFilesToDelete collection. UnitTestCase removes them consistently
during tearDown, including when a test fails early.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 610

  1. Benni Mack commented on patch set 1 09/23/26, 01:53

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Imaging/GraphicsCanvasTest.php
  2. Benni Mack commented on patch set 2 09/23/26, 01:54

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 09/23/26, 02:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109016

  4. core-ci voted on patch set 2 V -1 09/23/26, 02:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109017

  5. core-ci commented on patch set 2 09/23/26, 03:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109017

  6. Benni Mack rebased onto patch set 3 V -1 09/23/26, 12:12

  7. Benni Mack marked it ready for review 09/23/26, 12:19

  8. core-ci voted on patch set 3 V +1 09/23/26, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109047

  9. Benni Mack voted on patch set 3 CR +2 V +2 09/23/26, 12:29

  10. Benni Mack merged patch set 4 09/23/26, 12:29