Review main Work in progress Quiet

95987[FEATURE] Add connection option ignoreTables

Julian Mair CR -2 V 0 Normal +218 −9 updated 09/25/26, 08:25

Commit message

The database analyzer introspects every table of the Default
connection. A single column of a type Doctrine DBAL does not know,
for example the MariaDB VECTOR type, aborts the analysis of the whole
connection, even for a table that TYPO3 declares nowhere. Such a
table is also proposed for renaming and removal. So far, the only way
out is a separate database.

The new connection option "ignoreTables" lists the tables that TYPO3
ignores, no matter who or what manages them. They are passed to
Doctrine as a schema assets filter. Doctrine applies the filter
before it converts the columns of a table, so an ignored table is
never introspected. The tables are also removed from the expected
schema, so a declaration of the same name does not lead to a
CREATE TABLE statement.

The option works on every connection. On a connection other than
Default, it narrows the tables of the TableMapping configuration.

The schema assets filter is now reset after the comparison. It no
longer hides tables from later introspection on the same connection.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/87/95987/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/87/95987/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Stefan Bürk -2
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 3

Files 3

Review log 1114

  1. Julian Mair uploaded patch set 1 09/23/26, 06:16

  2. core-ci voted on patch set 1 V -1 09/23/26, 06:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109031

  3. Mathias Brodala commented on patch set 1 09/23/26, 06:52

    Feature-110761-IgnoreUnmanagedTablesInTheDatabaseAnalyzer.rst:6

    How to ignore managed tables in this case? ;-) Suggestion: "Ignore tables" and name the option "ignoreTables" accordingly. The important bit is that TYPO3 ignores the tables, no matter who or what manages them.
  4. Julian Mair uploaded patch set 2 V -1 09/23/26, 07:03

  5. Julian Mair commented on patch set 2 09/23/26, 07:04

    Feature-110761-IgnoreUnmanagedTablesInTheDatabaseAnalyzer.rst:6 Reply

    Done
  6. core-ci voted on patch set 2 V -1 09/23/26, 07:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109032

  7. Julian Mair updated the commit message in patch set 3 V -1 09/24/26, 11:19

  8. core-ci voted on patch set 3 V +1 09/24/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109148

  9. Stefan Bürk commented on patch set 3 CR -2 09/24/26, 11:36

    Thanks @julian.mair94@gmail.com for this change. However I'll put a -2 on this for now. The background for that decision is, that I'm already working on a complete refactoring of the whole database analyser stack (database comparision) and further handling (events/config options) for such points are on the list/todo as part of that process. That also includes that other points are still in investigation/decision state for that refactoring, like possible dismatling connection completly from the database compare or having "dedicated" schema handling/definitions for a connections - and layed out for v15. Thus, adding this now as feature hinders that process and work and I would have to take it as now introduced. I added this change in my working files for that process to pick it up at a concrete point or putting into the planned implementation relation chain until preceeding changes have been finished/made. Currently the latest change of that "working" chain is: * 95195: [WIP][!!!][TASK] Remove SchemaMigrator::install() | https://review.typo3.org/c/Packages/TYPO3.CMS/+/95195 I'll try to add that change into that change next week when continue working on that stack refactoring. This will most likely change by then.
  10. Julian Mair commented on patch set 3 09/24/26, 11:48

    Reply

    Thanks Stefan, makes sense. Feel free to take whatever helps from this change. Once it is part of your chain, I'm happy to test it against the real case (MariaDB 11.8, VECTOR column in the Default database). I'll leave this change open as a reference unless you'd prefer me to abandon it.
  11. Stefan Bürk commented on patch set 3 09/24/26, 15:05

    Reply

    Nope, leave it open for now. I'll just put it to WIP for you if that's okay.
  12. Stefan Bürk marked it work in progress 09/24/26, 15:06

  13. Julian Mair commented on patch set 3 09/24/26, 15:09

    This change is ready for review.

    Reply

    Sure, no problem.
  14. Stefan Bürk marked it work in progress 09/25/26, 08:25