Review 14.3 Merged

95991[BUGFIX] Check only type-relevant fields in linkvalidator

Benni Mack CR +2 V +2 Normal +65 −8 updated 09/23/26, 13:29

Commit message

Linkvalidator checks configured fields for broken links, but not all
fields are relevant for every record type. For example, tt_content
records with CType="div" do not use the bodytext field: it is not
shown in the backend form and not rendered in the frontend.

Previously, linkvalidator still checked such fields, reporting broken
links that editors cannot fix, since the field is not editable for
that CType. Opening the edit form from the report then shows an
incomplete form without the reported field.

This uses VisibleSchemaFieldsCollector to determine which fields are
actually part of the record's type (e.g. based on TCA "types"
configuration) and visible to the current backend user. Fields that
are not part of the resolved subschema are now skipped.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 57

  1. Benni Mack commented on patch set 1 09/23/26, 13:11

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php
  2. Benni Mack commented on patch set 2 09/23/26, 13:15

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/23/26, 13:16

  4. core-ci voted on patch set 2 V +1 09/23/26, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109059

  5. core-ci voted on patch set 1 V -1 09/23/26, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109057

  6. Benni Mack voted on patch set 2 CR +2 V +2 09/23/26, 13:29

  7. Benni Mack merged patch set 3 09/23/26, 13:29