Review 14.3 Merged

96040[TASK] Allow filtering e2e Playwright tests to a single file

Benni Mack CR +2 V +2 Easy +23 −6 updated 09/24/26, 17:38

Commit message

runTests.sh always ran the full Playwright e2e suite, forcing a full
docker/podman based instance boot plus all specs even when only a
single new or changed spec needed a quick check, unlike functional and
unit tests which already accept a path or "-- --filter" argument.

Forward trailing positional arguments (a spec file path, or other
Playwright CLI arguments such as "--grep <pattern>") to the underlying
"playwright test" invocation for the e2e, e2e-browser and e2e-prepare
suites, the same way "-s functional path/to/fileTest.php" already
works for PHP tests. The forwarded arguments are placed before
"--project", since Playwright parses "--project" as a variadic option
that would otherwise swallow a following file path as another project
name.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 09/24/26, 17:12

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Scripts/runTests.sh
  2. Benni Mack commented on patch set 2 09/24/26, 17:15

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 09/24/26, 17:15

  4. core-ci voted on patch set 1 V +1 09/24/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109173

  5. core-ci voted on patch set 2 V +1 09/24/26, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109174

  6. Benni Mack voted on patch set 2 CR +2 V +2 09/24/26, 17:38

  7. Benni Mack merged patch set 3 09/24/26, 17:38