Review 14.3 Merged

96048[TASK] Clean up file fixtures in unit tests

Georg Ringer CR +2 V +2 Easy +4 −15 updated 09/25/26, 08:13

Commit message

Register the lock test fixture with testFilesToDelete under TYPO3's
var path, outside the lock directory. The framework then removes it
even when an assertion fails.

Remove the rotating writer helper that deleted the file just after
the test created it. Construct the writer directly so the test covers
writing to an existing log file.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Georg Ringer commented on patch set 1 09/24/26, 20:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/24/26, 20:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109188

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/25/26, 08:13

  4. Georg Ringer merged patch set 2 09/25/26, 08:13