Review 14.3 Merged

96050[TASK] Make unit test assertions order sensitive

Georg Ringer CR +2 V +2 Easy +15 −15 updated 09/25/26, 08:14

Commit message

Put expected values first in assertions for graphical functions,
array utilities, Extbase object access, extension dependencies, and
external link errors so failures show the correct difference.

Use assertSame for Fluid template paths and TypoScript arrays so
changed key order fails. Rename the template path test to describe
the ascending numeric order it expects.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 34

  1. Georg Ringer commented on patch set 1 09/24/26, 21:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/24/26, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109192

  3. Georg Ringer voted on patch set 1 CR +2 V +2 09/25/26, 08:14

  4. Georg Ringer merged patch set 2 09/25/26, 08:14