Review 14.3 Merged

96066[TASK] Un-mark Connection::quoteIdentifier() override as deprecated

Stefan Bürk CR +2 V +2 Easy +2 −1 updated 09/25/26, 10:22

Commit message

Since #110254, `TYPO3\CMS\Core\Database\Connection::quoteIdentifier()`
overrides the deprecated Doctrine DBAL method. PHPStan still detects
the override as deprecated, as the `@deprecated` is inherited. Mark it
explicitly as not-deprecated.

https://phpstan.org/writing-php-code/phpdocs-basics#deprecations

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 45

  1. Stefan Bürk commented on patch set 1 09/25/26, 08:31

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/25/26, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109232

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 09/25/26, 09:11

  4. Stefan Bürk voted on patch set 1 CR +2 V +2 09/25/26, 10:22

  5. Stefan Bürk merged patch set 2 09/25/26, 10:22