Review 14.3 Merged

96108[BUGFIX] Keep daily task time across DST changes

Garvin Hicking CR +2 V +2 Normal +140 −2 updated 09/27/26, 10:23

Commit message

Recurring scheduler tasks with an interval were calculated by pure
timestamp arithmetic. A daily task (86400 seconds) started at 23:59
in a timezone with daylight saving time therefore ran at 00:59 after
the switch to summer time, and at 22:59 after the switch back.

Intervals that are a whole number of days are now stepped in local
time, so the wall-clock time of the task is kept. Other intervals,
such as hourly ones, stay strictly periodic.

The calculation moves into a separate method that takes the reference
time, which makes it testable. The PHP default timezone is used, which
is to be replaced by the backend user timezone later.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Garvin Hicking commented on patch set 1 09/27/26, 09:03

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 09/27/26, 09:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109364

  3. Garvin Hicking uploaded patch set 2 V -1 09/27/26, 10:10

    adapt for PHP 8 2 syntax
  4. core-ci voted on patch set 2 V +1 09/27/26, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109367

  5. Garvin Hicking voted on patch set 2 CR +2 V +2 09/27/26, 10:23

  6. Garvin Hicking merged patch set 3 09/27/26, 10:23