Review 14.3 Merged

96200[TASK] Document file converter resource classes

Garvin Hicking CR +2 V +2 Easy +4 −6 updated 09/30/26, 07:44

Commit message

Describe the expected core resource classes in the converter so
PHPStan can narrow the value after the type check. Remove the matching
baseline entry.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Garvin Hicking commented on patch set 1 09/30/26, 06:08

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  2. core-ci voted on patch set 1 V -1 09/30/26, 06:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109576

  3. Garvin Hicking uploaded patch set 2 V -1 09/30/26, 07:25

    backport
  4. core-ci voted on patch set 2 V +1 09/30/26, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109585

  5. Garvin Hicking marked it ready for review 09/30/26, 07:44

  6. Garvin Hicking voted on patch set 2 CR +2 V +2 09/30/26, 07:44

  7. Garvin Hicking merged patch set 3 09/30/26, 07:44