Review 14.3 Merged

96206[TASK] Remove redundant hidden field class check

Garvin Hicking CR +2 V +2 Easy +1 −7 updated 09/30/26, 08:04

Commit message

The isset() check already excludes null. Remove the redundant comparison
and its PHPStan baseline entry without changing the form output.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Garvin Hicking commented on patch set 1 09/30/26, 07:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 09/30/26, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109588

  3. Garvin Hicking rebased onto patch set 2 V +1 09/30/26, 07:45

    The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon
  4. Garvin Hicking uploaded patch set 3 09/30/26, 07:54

    backport
  5. core-ci voted on patch set 2 V -1 09/30/26, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109590

  6. core-ci voted on patch set 3 V +1 09/30/26, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109593

  7. Garvin Hicking marked it ready for review 09/30/26, 08:03

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 09/30/26, 08:04

  9. Garvin Hicking merged patch set 4 09/30/26, 08:04